hue: change default for disableHueEffects #5447
Conversation
|
I briefly considered renaming and inverting disableHueEffects, but we also have disableEffects which we toggle. So I opted to keep both it as disableHueEffects with a default of I also removed all the options where we manual set disableHueEffects to false before. |
lib/philips.js
Outdated
| const result = extendDontUse.light_onoff_brightness(options); | ||
| result['ota'] = ota.zigbeeOTA; | ||
| result['meta'] = {turnsOffAtBrightness1: true}; | ||
| result['toZigbee'] = result['toZigbee'].concat([philipsTz.hue_power_on_behavior, philipsTz.hue_power_on_error]); | ||
| if (!options.disableHueEffects) { |
There was a problem hiding this comment.
I don't think this should be removed, e.g. 046677562229 is known to support the effects>
There was a problem hiding this comment.
So do we keep onoff_brightness with the old default or do we also flip it? The few random ones i checked were not in the pdf vs all of the colortemp and color ones which were?
There was a problem hiding this comment.
Lets keep onoff_brightness it with the old default (disableHueEffects true)
There was a problem hiding this comment.
👍 will give this another pass tomorrow
|
Thanks again! 🏅 |
|
Thanks for doing this! |
As mentioned in Koenkk/zigbee2mqtt#16553, I grepped all our zigbeeModels and the first 25 were all on the list. I then randomly grabbed like another 10 and they were also listed.
I the noticed we had some light_onoff_brightness extends, these were not on the list from the PDF (makes sense) so these were not changed.