[Bitron AV2010/29A] Revert warning converter + add squawk command #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found the tuto https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/CONTRIBUTING.md |
|
@Koenkk : Perfect, it's tested. It works perfectly !! You can merge 😉 Unless you prefer to create another converter for warning_reverse... It will become hard to maintain a device list in the converter... |
|
Looks fine, thanks! |
muellermartin
added a commit
to muellermartin/zigbee-herdsman-converters
that referenced
this pull request
Nov 14, 2021
The Bitron AV2010/24A smoke detector behaves not as expected when mode, level and strobe are set for the warning capability. When the field order is flipped in the packet structure, the behaviour is as expected (as far as the options are supported). Related to Koenkk#2988 and Koenkk/zigbee2mqtt#8310
Koenkk
pushed a commit
that referenced
this pull request
Nov 15, 2021
The Bitron AV2010/24A smoke detector behaves not as expected when mode, level and strobe are set for the warning capability. When the field order is flipped in the packet structure, the behaviour is as expected (as far as the options are supported). Related to #2988 and Koenkk/zigbee2mqtt#8310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitron Smabit AV2010/29A seems to suffer the exact same mistake as Koenkk/zigbee2mqtt#8310.
This could explain why we need this strange controlling chapter on the device description that makes absolutely no sense : https://www.zigbee2mqtt.io/devices/AV2010_29A.html#controlling
I'm quite confident this is the solution.
PS : honestly i haven't test this commit, i don't know how to override an existing device or an existing converter on my home assistant installation (normal plugin / not edge version). Is there a tuto ?