Skip to content

Pass save file data through props instead of context #8

Open
@KockaAdmiralac

Description

@KockaAdmiralac

Right now, all saves are under the same context and controls that modify save file data (all of them) use the same context. This means that all the controls re-render whenever any control changes save file data. This does not currently create performance issues (aside from ones with the Steamworks ID editor... which were patched rather horribly) because the editor is not very big, but could create them in the future.

The solution to this is to have save files as state in the app, passed to their respective editors and controls through props. This way, only controls whose values were actually changed get re-rendered.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions