Skip to content

feat: use EJS on html files, inject process.env.* vars #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

Kocal
Copy link
Owner

@Kocal Kocal commented Oct 22, 2018

Q A
Bug fix? no
New feature? yes
Tests pass? yes
Fixed tickets ~

In order to load Vue Devtools remote <script> (#334 (comment)) only for development environment, a good solution is to use a condition (with EJS) on HTML files.

That means you can write:

<% if (NODE_ENV === 'development') { %>
<script src="http://localhost:8098"></script>
<% } %>

@Kocal Kocal merged commit 8171f3e into master Oct 23, 2018
@Kocal Kocal deleted the feat/use-ejs-on-html-files branch October 23, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant