Skip to content

Conversation

@Kocal
Copy link
Owner

@Kocal Kocal commented Nov 17, 2018

Close #136

Since #128, every JavaScripts files were seen as Vue component.
Now, .js files should at least have one @vue tag in a comment to be considered as a Vue component.

Recognized as a Vue component:

// Component.js

/**
 * @vue
 */
export default {
  name: 'Component',
}

Not recognized as a Vue component:

// File.js

export default {
  name: 'File',
}

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #137 into master will decrease coverage by 23.61%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #137       +/-   ##
===========================================
- Coverage   94.44%   70.83%   -23.62%     
===========================================
  Files           4        5        +1     
  Lines          36       48       +12     
  Branches        8       11        +3     
===========================================
  Hits           34       34               
- Misses          2       11        +9     
- Partials        0        3        +3
Impacted Files Coverage Δ
lib/core/issers.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6a464...735fa81. Read the comment docs.

@Kocal Kocal merged commit d57fc72 into master Nov 17, 2018
@Kocal Kocal deleted the fix/js-files-should-not-be-all-interpreted-as-a-vue-component branch November 17, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants