Skip to content

Adding Hooks Api #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding Hooks Api #6

wants to merge 2 commits into from

Conversation

leevigraham
Copy link

Hey guys,

This isn't complete but I wanted to kick off a discussion. I want to add the Repo Hooks Api to the library but I'm not 100% sure where.

  1. The Repo Hooks Api is listed under Repo (just like Teams is under Organisations) in the Github Docs.
  2. The library has getTeams() & addTeams() in the Organisation Api

So based on that I'm assuming the correct spot for the Repo Hook Api methods is in the Repo Api library.

Here's the new methods I plan to implement:

Also it looks like there is some inconsistency with naming methods. Repo::getRepoDownloads() vs Organisation::getTeam()

Thoughts?

* getRepoHook()
* addRepoHook()
* updateRepoHook()
* deleteRepoHook()
* testRepoHook()
@stloyd stloyd mentioned this pull request Jul 17, 2012
@leevigraham
Copy link
Author

#8 includes a hook api with a much cleaner codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant