Gists API #5
Closed
Gists API #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get single gist
| */ | ||
| public function getGist($id) | ||
| { | ||
| return $this->get('/gists/'.urlencode($id)); |
There was a problem hiding this comment.
Please remove first /, as with it API will generate wrong url.
| */ | ||
| public function update($id, $values) | ||
| { | ||
| return $this->patch('gists/'.urlencode($id), $values); |
There was a problem hiding this comment.
This needs to be changed as $values can be only in similar format to the create() method.
|
After mentioned changes, please squash your commits, after that I will merge it. Thanks! |
added gist api to client gist create api create gist api refactor delete gist api gist api functional test for getList method gist api refactor: renamed delete method in remove method unit tests for gist api functional test for gist api: get by id comment fix for gist api fix gist api documentation added delete method to gist api readme update readme update pull request fixes list all public gists small refactor list starred gists small refactor doc fix create gist method refactor gist update method refactor readme updated small refactor readme update
Conflicts: README.markdown lib/Github/Api/Gist.php test/Github/Tests/Api/GistTest.php test/Github/Tests/Functional/GistTest.php
|
Hi. Any news? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added basic gist api