Improve rate limit exceeded exception #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 14, 2016
| private $limit; | ||
| private $reset; | ||
|
|
||
| public function __construct($limit = 5000, $reset = 1800, $code = 0, $previous = null) |
There was a problem hiding this comment.
I would not add the new argument in the middle. It requires everyone using the exception themselves to update their code.
There was a problem hiding this comment.
Sure, but we are soon about to tag 2.0.0. So it is okey to break BC here.
Though, it should be documented in the change log of the next release.
There was a problem hiding this comment.
If this going to be only part of a new major release, this change is fine of course.
|
Could you rebase this PR on master so the test will run again? |
|
Sure |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two helpful methods to
ApiLimitExceedExceptionto allow getting the actual limit and reset time. I am working on a console application that needs to get the reset time in order to sleep until Github resets the token. Hope that makes sense, Thanks!