Update tests for PHPUnit 5.5 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Sep 19, 2016
|
@Nyholm I updated the PR, but it seems to me that the TravisCI error is due to the minimum stability setting and the dependencies. :( |
kokspflanze
reviewed
Sep 28, 2016
| @@ -97,9 +101,12 @@ public function testFetch() | |||
| $result = 'foo'; | |||
| $method = 'bar'; | |||
| $parameters = array('baz'); | |||
| $api = $this->getMock('Github\Api\ApiInterface'); | |||
| $api = $this->createMock('Github\Api\ApiInterface'); | |||
There was a problem hiding this comment.
createMock was added in PHPUnit 5.4 and PHPUnit 5.X is min PHP 5.6
There was a problem hiding this comment.
You can use getMockBuilder() instead which works on all supported PHPUnit versions without triggering deprecations.
|
👎 |
|
@GrahamCampbell Could you elaborate your comment? |
|
My comment was basically because of:
However, if the solution:
is implemented instead, then 👍. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.