Fixed archive download by reference #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the API docs, the reference should be passed directly as the last URL segment, not as a GET parameter. Check https://developer.github.com/v3/repos/contents/#get-archive-link Bug triaged by @garak. Closes KnpLabs#225
lrlopez
force-pushed
the
fix-get-archive
branch
from
ec06d33 to
fada3f3
Compare
|
can somebody merge this? :) |
|
👍 |
|
Changes LGTM 👍 Is there anything that needs to be done before this can be merged? This issue currently prevents bowerphp from installing any meaningful package version (Bee-Lab/bowerphp#111). |
pilot
added a commit
that referenced
this pull request
Feb 3, 2015
Fixed archive download by reference
|
can you please release a new minor version including this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the API docs, the reference should be passed directly as the last URL segment, not as a GET parameter.
Bug triaged by @garak.
Closes #225