Skip to content

Handle case of GitHub returning 204 No Content in some scenarios #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2024
Merged

Handle case of GitHub returning 204 No Content in some scenarios #1135

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a3f154
Handle case of GitHub returning 204 No Content in some scenarios whic…
tomcorbett Mar 22, 2024
4fff555
fix style issue raised by continuous-integration/styleci/pr
tomcorbett Mar 22, 2024
eaa7993
Added unit test for case of GitHub API returning 204 empty content in…
tomcorbett Mar 24, 2024
08c3d7a
Updated based on feedback from continuous-integration/styleci/pr
tomcorbett Mar 24, 2024
a3d2fb8
Another change requested by continuous-integration/styleci/pr (but no…
tomcorbett Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Another change requested by continuous-integration/styleci/pr (but no… 
…t for my changed code)
  • Loading branch information
@tomcorbett
tomcorbett committed Mar 24, 2024
commit a3d2fb821c49a83a65f27f4b8999e3d44532eed7
2 changes: 1 addition & 1 deletion test/Github/Tests/ResultPagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public function testFetchAllPreserveKeys()
'sha' => '43068834af7e501778708ed13106de95f782328c',
];

$response = new Response(200, ['Content-Type'=>'application/json'], Utils::streamFor(json_encode($content)));
$response = new Response(200, ['Content-Type' => 'application/json'], Utils::streamFor(json_encode($content)));

// httpClient mock
$httpClientMock = $this->getMockBuilder(HttpClient::class)
Expand Down