Add generics notation to MenuInterface

[emodric]

Solves errors by PHPStan similar to:

[garak]

I tried to run phpstan on codebase and it looks like there are much more points to fix.
What about to fix them all? At least with level 6

[emodric]

Well, this specifically is not about running PHPStan on this repo codebase, but when using Knp\Menu\MenuInterface in other packages, and runing PHPStan on those.

That being said, if I have time, I will take a look at running PHPStan here and see if I get it running at level 6.

[emodric]

I forgot to ask, in the meantime, can this be merged any maybe tagged (not super important), so it can be useful for other libs?

[core23]

Looks like you have to rebase this PR.

Hope this can be merged soon, as it would help many projects that are using phpstan / psalm.

[garak]

Looks like you have to rebase this PR.

No need to rebase, for now

[core23]

Travis is failing because of some generic phpunit error, that does not happen on the latest 2.x commit: https://travis-ci.org/github/KnpLabs/KnpMenu/builds/579731224

[emodric]

@garak Hi! What is the status of this PR? Is this something that is acceptable?

[emodric]

Thanks for the merge @garak ! Can we have a 2.6.1 patch release with the fix? :)

[garak]

Here you are: https://github.com/KnpLabs/KnpMenu/releases/tag/2.6.1

[emodric]

Thanks @garak ❤️