Skip to content

fix(plugin-pages): do not throw on empty page list #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

fix(plugin-pages): do not throw on empty page list #312

merged 1 commit into from
Apr 7, 2023

Conversation

GerkinDev
Copy link
Member

Closes #165

@GerkinDev GerkinDev added bug Something isn't working scope(plugin-pages) labels Apr 6, 2023
@GerkinDev GerkinDev force-pushed the fix/plugin-pages/empty-pages-list branch from 9c3637c to 4b2d5ba Compare April 7, 2023 21:17
@GerkinDev GerkinDev force-pushed the fix/plugin-pages/empty-pages-list branch from 4b2d5ba to dbd48be Compare April 7, 2023 22:16
@GerkinDev GerkinDev merged commit 582c2b9 into develop Apr 7, 2023
@GerkinDev GerkinDev deleted the fix/plugin-pages/empty-pages-list branch April 7, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working scope(plugin-pages)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash "Error: Could not set option "pluginPages:pages": Every root pages should set moduleRoot to true, or none" when pages is empty array
1 participant
@GerkinDev