Add support for Python 3.14, drop EOL 3.9#223
Merged
Conversation
Knio
reviewed
Apr 9, 2026
| branches: ["master"] | ||
| pull_request: | ||
| branches: ["master"] | ||
| on: [push, pull_request, workflow_dispatch] |
Owner
There was a problem hiding this comment.
tbh removing this branch restriction looks pretty fishy, like the start of a supply chain hack, but I'm going to accept it anyway because of your reputation, and because I don't care to re-learn how github actions work
Contributor
Author
There was a problem hiding this comment.
Thank you :)
Here's a brief explanation, happy to explain more and give examples, or feel free to ignore!
For push:
- It's best practice to submit new features from feature branches, and not from
master. - If we restrict to only
master, then I can't run the CI on my branch. - As seen here, I tested as I went along: https://github.com/hugovk/dominate/actions. Without this, I might have submitted a PR that fails, and I want to make sure it's passing first. Especially when changing support I want to test
- My other option is to develop in my own
master, which isn't great (for example, I can only test one branch at once, you can't push edits to my branch).
Similarly for pull_request:
- In https://github.com/python-pillow/Pillow, if a maintainer has more suggestions than can be made via the GH UI, we'll sometimes open a PR against the contributor's feature branch.
- With a branch restriction, the CI can't run in the fork.
btw https://github.com/zizmorcore/zizmor is a really good security linter. If you like, I'd be happy to add it here and address any findings it has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://devguide.python.org/versions/
Also it would be great to get a release at some point: the last was Dec 2023 and it'd be nice to get rid of the deprecation warning fixed in Dec 2024: #211. Thanks!