-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
add the reverse mode of temperature_fan #4983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion heating fans
…tion heating fans(fix line longer)
|
Many thanks for your contribution.
|
|
@CF3B5 I've been wanting something exactly like this. Thanks :) |
|
Thanks. As a high-level comment, I'm not really sure what this PR does. As a result, I think it will need a reviewer to help evaluate the benefits. -Kevin |
|
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
|
@KevinOConnor I think the intent is to use this to control things like under bed fans. You could have a set point for the chamber temperature, then use this to turn the fan off once the chamber temperature reaches that set point. At least that was my hope when I started watching this PR :) |
dingyifei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your commit message follow https://www.klipper3d.org/CONTRIBUTING.html#format-of-commit-messages
| #reverse: False | ||
| # If true, the working mode of the fan is reversed. If the temperature | ||
| # is lower than the target temperature, the fan speed increases; | ||
| # otherwise, the fan speed decreases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to mention the default is False
|
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
|
I'm a big fan of this. Works really nicely for adding a chamber heater as well. |
|
Really nice feature! I'm hoping it would be implemented :) |
|
Any update on this PR's status? |
add the reverse working mode of temperature_fan to some internal circulation heating fans.
Signed-off-by: Locke chen cf3b5bb@gmail.com