Skip to content

Conversation

@CF3B5
Copy link

@CF3B5 CF3B5 commented Dec 1, 2021

add the reverse working mode of temperature_fan to some internal circulation heating fans.

Signed-off-by: Locke chen cf3b5bb@gmail.com

@Sineos
Copy link
Collaborator

Sineos commented Dec 1, 2021

Many thanks for your contribution.
Without judging code or implementation:

@claytono
Copy link

@CF3B5 I've been wanting something exactly like this. Thanks :)

@KevinOConnor
Copy link
Collaborator

Thanks. As a high-level comment, I'm not really sure what this PR does. As a result, I think it will need a reviewer to help evaluate the benefits.

-Kevin

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@claytono
Copy link

@KevinOConnor I think the intent is to use this to control things like under bed fans. You could have a set point for the chamber temperature, then use this to turn the fan off once the chamber temperature reaches that set point. At least that was my hope when I started watching this PR :)

Copy link
Contributor

@dingyifei dingyifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#reverse: False
# If true, the working mode of the fan is reversed. If the temperature
# is lower than the target temperature, the fan speed increases;
# otherwise, the fan speed decreases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to mention the default is False

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Apr 3, 2022
@kmobs
Copy link
Contributor

kmobs commented Feb 22, 2023

I'm a big fan of this. Works really nicely for adding a chamber heater as well.

@Henlor
Copy link

Henlor commented Mar 8, 2023

Really nice feature! I'm hoping it would be implemented :)

@dingyifei
Copy link
Contributor

Any update on this PR's status?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants