Adds support for the STEVAL-3DP001V1 board from STmicroelectronics #4835
Conversation
…ipper into STEVAL3DP001V1_work
JamesH1978
left a comment
JamesH1978
left a comment
There was a problem hiding this comment.
Thank you for submitting your config.
Please make sure that you follow the steps in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md especially the point on regression tests.
Also please see my added comments.
Whereas I can review the configuration @KevinOConnor or another reviewer will have to review your extra code for the driver additions etc.
Thanks
James
| @@ -0,0 +1,327 @@ | |||
| # This file contains common pin mappings for STEVAL-3DP001V1 board. | |||
| # to use this config, the firmware should be compiled for the STM32F4 | |||
There was a problem hiding this comment.
This will need to be expanded on, it has no mention of how you should set the make menuconfig, clocks, speeds, bootloader offsets etc. and then the method of flashing this file.
|
|
||
| [mcu] | ||
| serial: /dev/serial/by-id/usb-STMicroelectronics_STM32_STLink_0674FF514852897267245621-if02 | ||
| baud: 115200 |
There was a problem hiding this comment.
You have stated a custom speed, we generally do not set this unless their is a very good reason to do so, 250000 default works on the majority of known boards. Have you tested that it will not work at the default speed?
|
This PR was inadvertently closed due to a regression introduced by #6293. -Kevin |
|
It seems this PR "slipped through the cracks" on my side. Can you provide an update on the current status? Is this something that should still be merged? -Kevin |
|
It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket. Best regards, PS: I'm just an automated script, not a human being. |
3 participants
This PR supersedes #4392 .
Signed-off-by: Oussama HOUIDAR houidar.ousama@gmail.com