Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerized local development setup and basic CI pipeline with compile #7

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

0xAurelius
Copy link
Contributor

@0xAurelius 0xAurelius commented Mar 4, 2022

Allows for easier and more consistent local development and ensures contracts always compile

docker-compose.yml Outdated Show resolved Hide resolved
@0xAurelius 0xAurelius changed the title Add Dockerized local development setup Add Dockerized local development setup and basic CI pipeline with compile Mar 11, 2022
@0xAurelius 0xAurelius marked this pull request as ready for review March 11, 2022 00:36
@0xAurelius 0xAurelius force-pushed the main branch 7 times, most recently from 18f3080 to 0461459 Compare March 11, 2022 01:34
docker-compose.yml Outdated Show resolved Hide resolved
@0xmichalis
Copy link
Contributor

Not sure what prompted the addition of the docker-compose file but I'd recommend avoiding it altogether if possible because there are various differences between Linux and Mac environments that make it really annoying to maintain containerized environments and I think for basic build + deploy of smart contracts we should be able to get away without a containerized environment.

@0xAurelius
Copy link
Contributor Author

I only added it because I was struggling with my local non-containerized npm setup and I figured other people would run into similar issues

I had a really nice experience with Lens Protocol's containerized dev environment so figured I would implement something similar here: https://github.com/aave/lens-protocol

Of course, there's no reason you couldn't still use bare npm on your local machine even with a containerized option

We can adjust the README to clarify both local dev workflows

@0xmichalis
Copy link
Contributor

I only added it because I was struggling with my local non-containerized npm setup and I figured other people would run into similar issues

I had a really nice experience with Lens Protocol's containerized dev environment so figured I would implement something similar here: https://github.com/aave/lens-protocol

Of course, there's no reason you couldn't still use bare npm on your local machine even with a containerized option

We can adjust the README to clarify both local dev workflows

Sounds good to me.

.bash_history Outdated Show resolved Hide resolved
@0xAurelius 0xAurelius merged commit 51a5a6f into KlimaDAO:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants