Enable coredump for containerized applications #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KjellKod
approved these changes
Nov 22, 2021
| // When running as PID1 the above kill doesn't have any effect (execution simply passes through it, contrary | ||
| // to a non-PID1 process where execution stops at kill and switches over to signal handling). Also as PID1 | ||
| // we must unblock the thread that received the original signal otherwise the process will never terminate. | ||
| gBlockForFatal = false; |
There was a problem hiding this comment.
Good comments that explain this small but non-trivial system
insight
GergoTot
added a commit
to GergoTot/g3log
that referenced
this pull request
Mar 3, 2023
…er with PID 1 aborted Our service (running in Docker and PID 1) was crashed with SIGABRT signal. After SIGABRT dropped then unfortunatlly infinite SIGSEGV signals were also started to drop. So the infinite loop stucked since the kill signal doesn't stop the infinite loop when running in Docker container with PID 1. We used the similar solution mentioned this PR: KjellKod#419. We also had to restore the saved signal handlers. Without it infinte SIGSEGV signals were dropped circully and this situation also caused pending when running in Docker container with PID 1.
Closed
GergoTot
added a commit
to GergoTot/g3log
that referenced
this pull request
Mar 3, 2023
…ith PID 1 aborted Our service (running in Docker and PID 1) was crashed with SIGABRT signal. After SIGABRT dropped then unfortunatlly infinite SIGSEGV signals were also started to drop. So the infinite loop stucked since the kill signal doesn't stop the infinite loop when running in Docker container with PID 1. We used the similar solution mentioned this PR: KjellKod#419. We also had to restore the saved signal handlers. Without it infinte SIGSEGV signals were dropped circully and this situation also caused pending when running in Docker container with PID 1.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains the proposed fix for issue #418.
It unblocks the fault signal handler after the log/stacktrace has been flushed. The mechanism is reused from the windows crash handler where this unblocking was already implemented. The modification does not affect non-containerized native processes (non-PID1) as the final step after the flush is re-emitting the fatal signal (
kill) and code execution for the process stops here. For containerized processes thekillis passed and ignored and unblocking the sleep in the fault signal handler takes place. This enables the containerized process to exit and create a core-dump.There are no testing or documentation activities done.
New/modified code must be backed down with unit test - preferably TDD style development)
All new/modified functionality should be backed up with API documentation (API.markdown or README.markdown)
Cross-Platform Testing
Testing Advice
Run Test Alternatives:
ctestctest -Vfor verbose outputmake test