Fix CMake interface include directories #321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #319 .
It turns out to be a mistake I made in #312 .
In that PR, I changed these lines:
to:
but I forgot to take care of
COMPONENT
.COMPONENT libraries
should be together withLIBRARY
/ARCHIVE
/RUNTIME
, but not withINCLUDES
.And this mistake causes
INTERFACE_INCLUDE_DIRECTORIES
to be set incorrectly ing3loggerTargets.cmake
:which, instead, should be set as: