Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS builds don't honor disabling ENABLE_FATAL_SIGNALHANDLING settings for all architectures #309

Closed
mobileben opened this issue Mar 20, 2019 · 1 comment
Closed

iOS builds don't honor disabling ENABLE_FATAL_SIGNALHANDLING settings for all architectures #309

mobileben opened this issue Mar 20, 2019 · 1 comment

Comments

@mobileben
Copy link
Contributor

This is my bad. I left this out of the IOSBuild.cmake file. It turns out I need to disable fatal signal handling because it interferes with crash logging.

I already have a branch for this in my fork and have verified it works.
@mobileben mobileben changed the title iOS builds don't honor ENABLE_FATAL_SIGNALHANDLING settings for all architectures iOS builds don't honor disabling ENABLE_FATAL_SIGNALHANDLING settings for all architectures Mar 20, 2019
mobileben pushed a commit to mobileben/g3log that referenced this issue Mar 20, 2019
KjellKod#309 properly pass through ENABLE_FATAL_SIGNALHANDLING for th…
18243f9 
…e various iOS slices
@mobileben mobileben mentioned this issue Mar 20, 2019
Merged
KjellKod pushed a commit that referenced this issue Mar 22, 2019
@mobileben
#309 properly pass through ENABLE_FATAL_SIGNALHANDLING for the variou…
9c5e7f3 
…s iOS slices (#310)
@KjellKod
Copy link
Owner

Done with: #310

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KjellKod @mobileben