fix(SplineWidget): lastHandle may not show after loseFocus #3383
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SplineWidget adds new points through left mouse button clicks and confirms all points by pressing the Enter key on the keyboard.
The bug reproduction steps are as follows:
The expected result is that the third point should also be added to the SplineWidget. The cause of this phenomenon is that after the last added point, as long as the mouse hasn't moved, the visible property of model.lastHandle won't be updated to true, causing vtkSplineContextRepresentation to not render the last point.
Results
After the modification, the last point can now be correctly rendered in the above situation.
Changes
The fix is simply to add one line in the SplineWidget's loseFocus function: if lastHandle exists, set its visible property to true.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting