fix(vtkOpenGLRenderWindow): Remove unused HaveVRDisplay event and outdated TypeScript definitions
#2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `vtkOpenGLRenderWindow.HaveVRDisplay` event. This event is unused internally and was previously left over from WebVR to WebXR integration to avoid API breakage. Under previous behavior the `navigator.xr` check was called eagerly at construction, which could result in an unhandled exception. This change removes that eager check so that `navigator.xr` is referenced only if an XR-related method such as `startXR` is called. Applications should query `navigator.xr` directly to determine whether a given session type may be supported. Resolves Kitware#2537
Removes outdated WebVR TypeScript definitions from `vtkOpenGLRenderWindow`. Affected definitions were previously removed during the transition from WebVR to WebXR support.
Contributor
Author
Contributor
|
LGTM code-wise. |
PaulHax
approved these changes
Jul 27, 2023
Contributor
Author
|
🎉 This PR is included in version 28.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
vtkOpenGLRenderWindow.HaveVRDisplayevent. This event is unused internally and was previously left over from WebVR to WebXR integration to avoid API breakage.Under previous behavior the
navigator.xrcheck was called eagerly at construction, which could result in an unhandled exception. This change removes that eager check so thatnavigator.xris referenced only if an XR-related method such asstartXRis called.Applications should query
navigator.xrdirectly to determine whether a given session type may be supported.Resolves #2537
Also removes outdated WebVR-related TypeScript definitions from
vtkOpenGLRenderWindow. Affected method implementations were previously removed in transition from WebVR to WebXR.Context
navigator.xris only available where WebXR is supported, and sometimes appears available but is disabled for security. Queries should be limited to instances where XR is explicitly being used, or at least exceptions should be handled otherwise.Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting
master