chore(WebGPU): more volume support, add bind group #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flesh out the multivolume renderer a bit more Add a bind group class as WebGPU only requires support for 4 bind group layouts and the old approach could easily go past 4. With the bind group class we typically only have two bind groups active, one for the renderer and one for the mapper. Tons of changes to support this.
martinken
force-pushed
the
webgpu_fixe_register
branch
from
cc00131 to
363669c
Compare
|
🎉 This PR is included in version 18.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flesh out the multivolume renderer a bit more
Add a bind group class as WebGPU only requires support for 4 bind group
layouts and the old approach could easily go past 4. With the bind group
class we typically only have two bind groups active, one for the
renderer and one for the mapper. Tons of changes to support this.