Webgpu multi vol #1919
Merged
Webgpu multi vol #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic structure for multi volume rendering Rework a lot of the structure of the WebGPU support. 1) Make BindGroupLayouts more generic where you request them with a description and the device caches them and either returns or creates as needed. 2) make bindable things more generic so they can be lumped into one group and treated the same. This include UBOs, SSBOs, and TextureViews 3) add a mapper helper that is meant to be a minimal mapper. The idea is that PolyDataMapper would internally use four of these simpler mappers, one for each cellArray (verts, lines, polys, strips). Then other classes could make use of the simpler mapper helper directly when such complexity isn't needed. 4) Make the renderencoder the more important part of rendering. Previously some calls were passed the pipleine that now get passed the render encoder. The renderencoder has a bound pipeline so while those two things (pipeline and renderencoder) are a bit independent of each other, during rendering the renderencoder will have a pipeline and tends to live (be bound) longer than the pipeine so it is what gets passed.
martinken
force-pushed
the
webgpu_multi_vol
branch
from
26dfb39 to
4edcf2a
Compare
Create a MapperHelper class that renders one cellarray and can be used by many mapper. PolyDataMapper creates 4 of these, one for each cell array it holds. Make the BindGroupLayout code more general, remove old hardcoded binggrouplayout names. Make the shader replacement approach more clear and consistent. Fix an issue with SSBOs not resizing correctly.
martinken
force-pushed
the
webgpu_multi_vol
branch
from
4edcf2a to
5690b08
Compare
|
🎉 This PR is included in version 18.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.