fix: add missing dataAccessHelper imports in examples #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jourdain WDYT ? |
|
Just rename your commit to be |
|
Otherwise it looks good |
boucaud
force-pushed
the
fixDataAccessHelperExamples
branch
from
c1d9bd2 to
b3fc6bb
Compare
Done |
|
🎉 This PR is included in version 18.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Individual DataAccessHelper files now need to be imported in order to be registered.
Changes
Add imports for JSZipDataAccesHelper in the animation examples.
Results
These examples work again
Testing