Skip to content

docs(ts): move primitive vtk interfaces to interfaces.d.ts #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

docs(ts): move primitive vtk interfaces to interfaces.d.ts #1902

merged 1 commit into from
May 10, 2021

Conversation

daker
Copy link
Collaborator

@daker daker commented May 8, 2021

Context

Refactor Typescript definitions

Changes

  • Move VtkObject, VtkAlgorithm, vtkRange to interfaces.d.ts
  • Rename VtkObject to vtkObject
  • Rename VtkAlgorithm to vtkAlgorithm

Results

No changes in behavior but vtkObject type/interface can be imported from interfaces.d.ts rather than macro.d.ts

Testing

Other vtk classes which extend vtkObject are still working
image

vtkObject used as a type
image

@daker daker force-pushed the add-ts-interfaces branch from 70c38aa to e464c96 Compare May 8, 2021 22:35
@jourdain jourdain merged commit 4247862 into Kitware:master May 10, 2021
@github-actions
Copy link

🎉 This PR is included in version 18.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jourdain jourdain jourdain approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daker @jourdain