ESM: avoid critical dependency webpack warning #1901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using the
@kitware/vtk.js
package, webpack users would run into aCritical dependency
warning, like the one below.Changes
We switch to using the polyfill rollup plugin in order to polyfill out stream (and readable-stream).
Results
Initial testing indicates that the polyfill works and the error does not occur in webpack builds that consume
@kitware/vtk.js
.