fix(actor): prevent serialization of actors without a mapper#98
Merged
fix(actor): prevent serialization of actors without a mapper#98
Conversation
finetjul
reviewed
Dec 19, 2025
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Please add in your commit comment how to reproduce the issue you had.
jourdain
approved these changes
Dec 20, 2025
Fix bug where oglmapper wass undefined in traverseOpaquePass for an actor whose visibility got toggled twice
Jo-Byr
force-pushed
the
fix-actor-serialization
branch
from
6a557f7 to
b116bc9
Compare
Serialize actors on condition of having a mapper and a property instance, or on visibility turn off
Contributor
Author
luciemac
approved these changes
Jan 27, 2026
Collaborator
|
You've done more testing than me, so I trust you here. I don't see anything specifically wrong on that code change. Feel free to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.