Migrate build summary page to DaisyUI #3259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This table is effectively identical to index.php
josephsnyder
requested changes
Nov 24, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Functionally, looks really good. I have one thing I'd like to see updated:
The "Comment" box loses the border, which might make it feel like some part of the page hasn't loaded:
Before :
After :
It does get a nice highlight upon clicking into the box, but I think it could be made more obvious that a text box is there.
Collaborator
Author
|
@josephsnyder Good catch, I forgot about that since I wasn't logged in locally. I updated the input elements to use DaisyUI styling, in line with the previous behavior. I think the UI (both before and after) is pretty ugly for comments, so I'll plan to make a follow-up PR to clean it up a bit. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
This PR brings the standardized build summary card, code box formatting, and general DaisyUI availability to the build summary page. I also did a light cleanup of the code and functionality, with a more thorough cleanup to be done in a follow-up PR.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
#3259 updated the header of the build summary page, which deleted the link to the notes page in the process. This PR re-adds it as a dedicated section. I plan to move all of the links to `/builds/<id>/*` pages to a new sidebar UI element in the next 1-3 releases, so I expect this solution to be a temporary fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the standardized build summary card, code box formatting, and general DaisyUI availability to the build summary page. I also did a light cleanup of the code and functionality, with a more thorough cleanup to be done in a follow-up PR.