Expose time status via GraphQL #3223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Things look good! No problem with the GraphQL interactions but one question before approval:
In the Test Timing data that we have, "Time Status" not only has Pass/Fail but a Warning state in the GUI. This appears in the webpage even when the migration in this PR had been run.
Should we introduce a Warning state?
josephsnyder
approved these changes
Oct 29, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Thanks for the F2F! I think the plan ahead is solid and this is ready to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build2test.timestatuscolumn currently encodes information about both the binary "did this test instance pass the time check" and an aggregate across previous test instances indicating "does this chunk of tests represent a change in test time". This PR exposes just the former portion, returning a binary passed/failed value corresponding to the exact test record being retrieved. The rest of the information about aggregate test timing will be exposed via a separate field in the future.