Fix coverage percent display bug when no executable lines #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
coverage-file-percent-bugfix
branch
from
98a7161 to
ef258e2
Compare
josephsnyder
approved these changes
Oct 15, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Much better display. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage file UI currently shows "NaN" when there are no executable lines of code in the file. Since the behavior in such a case is undefined, it's better to just hide the percent display unless there are lines to calculate a percentage from.