Skip to content

Fix divide-by-zero bugs on coverage page #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackgalbreath merged 1 commit into from
Oct 8, 2025
Merged

Fix divide-by-zero bugs on coverage page #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/Http/Controllers/CoverageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,11 @@ public function viewCoverage(): View|RedirectResponse

$covfile['coveragemetric'] = ($coveragefile_array['loctested'] + 10) / ($coveragefile_array['loctested'] + $coveragefile_array['locuntested'] + 10);
$coveragetype = 'gcov';
$covfile['percentcoverage'] = sprintf('%3.2f', $coveragefile_array['loctested'] / ($coveragefile_array['loctested'] + $coveragefile_array['locuntested']) * 100);
if ((int) $coveragefile_array['loctested'] + (int) $coveragefile_array['locuntested'] > 0) {
$covfile['percentcoverage'] = sprintf('%3.2f', (int) $coveragefile_array['loctested'] / ((int) $coveragefile_array['loctested'] + (int) $coveragefile_array['locuntested']) * 100);
} else {
$covfile['percentcoverage'] = '100.00';
}
}

// Add the number of satisfactory covered files
Expand Down Expand Up @@ -641,7 +645,12 @@ public function ajaxGetViewCoverage(): JsonResponse
$covfile['branchpercentcoverage'] = sprintf('%3.2f', $metric * 100);
$covfile['branchcoveragemetric'] = $metric;

$covfile['percentcoverage'] = sprintf('%3.2f', $covfile['loctested'] / ($covfile['loctested'] + $covfile['locuntested']) * 100);
if ((int) $covfile['loctested'] + (int) $covfile['locuntested'] > 0) {
$covfile['percentcoverage'] = sprintf('%3.2f', (int) $covfile['loctested'] / ((int) $covfile['loctested'] + (int) $covfile['locuntested']) * 100);
} else {
$covfile['percentcoverage'] = '100.00';
}

$covfile['coveragemetric'] = ($covfile['loctested'] + 10) / ($covfile['loctested'] + $covfile['locuntested'] + 10);
$coveragetype = 'gcov';
}
Expand Down
10 changes: 2 additions & 8 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,7 +1281,7 @@ parameters:
-
rawMessage: 'Method App\Http\Controllers\CoverageController::ajaxGetViewCoverage() throws checked exception DivisionByZeroError but it''s missing from the PHPDoc @throws tag.'
identifier: missingType.checkedException
count: 3
count: 2
path: app/Http/Controllers/CoverageController.php

-
Expand Down Expand Up @@ -1377,7 +1377,7 @@ parameters:
-
rawMessage: 'Method App\Http\Controllers\CoverageController::viewCoverage() throws checked exception DivisionByZeroError but it''s missing from the PHPDoc @throws tag.'
identifier: missingType.checkedException
count: 2
count: 1
path: app/Http/Controllers/CoverageController.php

-
Expand Down Expand Up @@ -1464,12 +1464,6 @@ parameters:
count: 2
path: app/Http/Controllers/CoverageController.php

-
rawMessage: 'Only numeric types are allowed in /, (array|float|int) given on the right side.'
identifier: div.rightNonNumeric
count: 2
path: app/Http/Controllers/CoverageController.php

-
rawMessage: 'Only numeric types are allowed in /, (array|float|int<1, max>) given on the right side.'
identifier: div.rightNonNumeric
Expand Down