Move version computation out of Mix build #3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Oct 6, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
File properly appears after both manual run of version and cdash_install --dev. No issues here!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
I forgot to remove `git-revision-webpack-plugin` from our `package.json` in #3171.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Follows #3171. Now there is only a single place the version needs to be set when releases are created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VERSIONfile is currently generated during the Mix build, which hinders our ability to migrate to Vite in the future. This PR creates a new Laravel command which performs the same actions.