Sort testSummary rows deterministically in e2e test #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
One unrelated failure in the |
Collaborator
Author
|
10 runs passed successfully, minus a couple unrelated flakes. Ready for review, and hopefully this will resolve this longstanding issue! |
josephsnyder
approved these changes
Sep 25, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Seems reasonable and local testing has no issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-summary.cy.jshas been flaky for years and is quite a nuisance when unrelated changes modify the test timing subtly and upset this delicate test. See the trouble merging #3132 for an example. My hypothesis is that somehow the rows in the table are not rendered deterministically. This PR attempts to resolve that by sorting by build stamp. I intend to run the tests 10 times before opening this for review to ensure that this fix actually does something.