Index build2test(buildid,status)
#3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Sep 11, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
No duplications and installs without issue. LGTM!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no way for Postgres to efficiently query tests by status for a given build. The best query plan with the current setup is simply for Postgres to scan all of the tests for a given build. Scanning all tests is reasonably efficient in most cases, but the overhead adds up over time for this extremely common use case. This PR indexes
build2test(buildid,status)to allow the database to count the number of passing or failing tests directly.