Revamp coverage file UI #3108
Revamp coverage file UI #3108
Conversation
williamjallen
force-pushed
the
coverage-file-ui-refactor
branch
from
bf264f7 to
14166a2
Compare
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
I'm unable to see coverage data. The new page (builds/####/coverage/###) loads but the spinning wheel where the line-by-line information doesn't go away. There are no issues in the console nor did any of the network calls fail.
Though, looks like the page got no data back from the coverage graphql call:
|
@josephsnyder Does that coverage file ID exist? |
@williamjallen I was just checking that and the IDs don't line up. CDash's links say the file id should be |
|
@josephsnyder Ah, good catch! The page links to the |
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Much better. Thanks for the fix!
Building on the work in #3108, this PR adds a reusable code box with line numbers for use across the site. This component is expected to eventually replace all of the existing prepared text boxes used for displaying build and test output. I used the new component on the build notes page as an example and will create follow-up PRs to increase the usage across the site.
2 participants
The current UI for viewing individual coverage files is outdated, the technical implementation is poor for a multitude of reasons, and branch coverage is currently entirely broken. This PR completely replaces the page with a brand new Vue-based UI.
Before:
After:
