Remove label subscriptions #3066
Conversation
williamjallen
force-pushed
the
remove-label-subscription
branch
from
0d4a8d5 to
4fbf507
Compare
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
One requested update about a link to nowhere, but also a further question: is this page just fundamentally broken?
I don't see the save button appear when edits are made to the selections or even some of the headers like the hidden Email me: element which makes the selections starting with when ... actually make sense. They all appear to be hidden by a if test="/cdash/edit=1"
williamjallen
force-pushed
the
remove-label-subscription
branch
from
4fbf507 to
8570600
Compare
|
@josephsnyder I had the same thought at first--it took me a while to realize that you need to add |
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Thanks for the answer and the update. LGTM!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Following the discussion in #3066 (review), this PR removes the unnecessary `edit` query parameter from the project notifications page. A PR which completely overhauls this page is planned for the future, but this temporary improvement is good enough for now.
2 participants
CDash historically offered the ability to subscribe to notifications on a per-label basis, meaning that users could subscribe to the portion of the errors relevant to them without being bothered by errors related to other parts of the codebase. This functionality is currently broken, causes performance issues for several fundamental reasons, and is entirely untested. This PR removes the feature entirely. If a similar feature is desired in the future, we can re-evaluate it as a new feature designed and written from the ground up.