Force-drop database before tests #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
approved these changes
Aug 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
It's currently very annoying to run the tests while simultaneously poking around in the database because Postgres doesn't allow databases with other active connections to be dropped. In my case, I almost always forget to terminate my connection prior to running the tests and have to re-run the test suite as a result multiple times per day. By adding the `FORCE` option, the test suite can proceed while other connections are active. Those connections will be terminated and can be restarted once developers want to go back to exploring the database manually.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently very annoying to run the tests while simultaneously poking around in the database because Postgres doesn't allow databases with other active connections to be dropped. In my case, I almost always forget to terminate my connection prior to running the tests and have to re-run the test suite as a result multiple times per day. By adding the
FORCEoption, the test suite can proceed while other connections are active. Those connections will be terminated and can be restarted once developers want to go back to exploring the database manually.