Increase build2test primary key to bigint type
#3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Follows #3054. For systems where many tests have associated images, the `image` table can be close to the size of the `build2test` table. The goal is to eventually change all ID columns to bigints, but I'd like to let these two roll out first before proceeding with the rest to make sure there are no lingering issues with this change, especially for databases migrated from MySQL in the past.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
All ID columns should be bigints to avoid the potential for overflow errors. Follows #3054 which addressed the most urgent need. Depending on the column ordering (which may be different between systems due to historical migration differences), this migration may require some or all of the affected tables to be rewritten. Some of the affected tables can be quite large on production systems and it's likely that table rewrites could take hours to complete depending on the total size and speed of the underlying storage medium.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build2testprimary key column currently uses an integer type. Bigints are recommended for primary keys in Postgres since they are effectively impossible to overflow. This PR changes the type from int to bigint to avoid a sequence overflow observed on one of our large production systems.