Fix undefined class warnings

app/Console/Commands/QueueSubmissions.php

@@ -6,7 +6,7 @@
 use App\Utils\AuthTokenUtil;
 use CDash\Model\Project;
 use Illuminate\Console\Command;
-use Storage;
+use Illuminate\Support\Facades\Storage;
 
 class QueueSubmissions extends Command
 {

app/cdash/app/Lib/Repository/GitHub.php

@@ -151,7 +151,7 @@ public function authenticate(bool $required = true): bool
         try {
             $token = $this->apiClient->api('apps')->createInstallationToken($this->installationId);
         } catch (Exception $e) {
-            \Log::error($e->getMessage());
+            Log::error($e->getMessage());
             return false;
         }
         if ($token) {

app/cdash/app/Model/Build.php

@@ -95,7 +95,7 @@ class Build
     public string $BeginningOfDay;
     public string $EndOfDay;
 
-    private $TestCollection;
+    private Collection $TestCollection;
     private $PDO;
     private $Site;
     private $BuildUpdate;
@@ -2192,10 +2192,8 @@ public function AddTest(Test $buildtest): self
 
     /**
      * Return the current Build's TestCollection.
-     *
-     * @return TestCollection
      */
-    public function GetTestCollection()
+    public function GetTestCollection(): Collection
     {
         return $this->TestCollection;
     }

app/cdash/app/Model/BuildConfigure.php

@@ -38,7 +38,7 @@ class BuildConfigure
     public $BuildId;
     public $NumberOfWarnings;
     public $NumberOfErrors;
-    public $LabelCollection;
+    public Collection $LabelCollection;
     private $Crc32;
 
     private $PDO;

app/cdash/include/Messaging/Topic/MissingTestTopic.php

@@ -19,13 +19,20 @@
 
 use App\Models\Test;
 use CDash\Model\Build;
+use Illuminate\Support\Collection;
 
 class MissingTestTopic extends Topic
 {
     use IssueTemplateTrait;
 
-    /** @var Illuminate\Support\Collection */
-    private $collection;
+    private Collection $collection;
+
+    public function __construct(?TopicInterface $topic = null)
+    {
+        parent::__construct($topic);
+
+        $this->collection = collect();
+    }
 
     /**
      * This method queries the build to check for missing tests
@@ -53,14 +60,8 @@ public function setTopicData(Build $build)
         }
     }
 
-    /**
-     * @return Illuminate\Support\Collection
-     */
-    public function getTopicCollection()
+    public function getTopicCollection(): Collection
     {
-        if (!$this->collection) {
-            $this->collection = collect();
-        }
         return $this->collection;
     }
 

app/cdash/include/common.php

@@ -27,6 +27,7 @@
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Storage;
 use League\Flysystem\UnableToReadFile;
 use Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException;
 

app/cdash/tests/case/CDash/TestUseCaseTest.php

@@ -1,6 +1,7 @@
 <?php
 
 use App\Http\Submission\Handlers\TestingHandler;
+use App\Models\Test;
 use CDash\Collection\BuildCollection;
 use CDash\Model\Build;
 use CDash\Test\CDashUseCaseTestCase;
@@ -173,11 +174,9 @@ public function testTestUseCaseCreatesTestPassed()
 
         /** @var TestingHandler $handler */
         $handler = $sut->build();
-        /** @var BuildCollection $builds */
         $builds = $handler->GetBuildCollection();
         /** @var Build $build */
         $build = $builds->current();
-        /** @var Collection $tests */
         $tests = $build->GetTestCollection();
         /** @var Test $test */
         $test = $tests->get('some.test.name');

app/cdash/tests/test_branchcoverage.php

@@ -11,6 +11,7 @@
 use CDash\Model\Build;
 use CDash\Model\PendingSubmissions;
 use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
 
 class BranchCoverageTestCase extends KWWebTestCase
 {

app/cdash/tests/test_deferredsubmissions.php

@@ -10,6 +10,8 @@
 use App\Models\AuthToken;
 use App\Utils\DatabaseCleanupUtils;
 use CDash\Model\Project;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
 
 class DeferredSubmissionsTestCase extends BranchCoverageTestCase
 {

app/cdash/tests/test_parallelsubmissions.php

@@ -10,6 +10,7 @@
 
 use App\Utils\DatabaseCleanupUtils;
 use CDash\Model\Project;
+use Illuminate\Support\Facades\DB;
 
 class ParallelSubmissionsTestCase extends TrilinosSubmissionTestCase
 {

app/cdash/tests/test_unparsedsubmissionshonorbuildid.php

@@ -8,6 +8,7 @@
 require_once 'tests/test_branchcoverage.php';
 
 use App\Utils\DatabaseCleanupUtils;
+use Illuminate\Support\Facades\DB;
 
 class UnparsedSubmissionsHonorBuildIdTestCase extends BranchCoverageTestCase
 {