Add return types to "safe" functions #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Jul 31, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM! Didn't read every line but spot-checking seemed reasonable.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2025
The `void_return` rule was previously disabled due to other broken type annotations trickling through the inheritance hierarchy and causing it to choose the wrong annotations. Now that #3011 is complete, this is no longer an issue and the `void_return` fixer can be re-enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP type annotations improve static analysis because static analysis tools can make stronger guarantees about types further down the AST. These type hints are immensely useful for developers using PHP-specific IDEs such as myself. This PR adds type annotations to many functions throughout the codebase where the return type is immediately clear from a brief inspection of the implementation. In addition to clearing nuisance warnings in my IDE, PHPStan analysis is improved as can be seen from some of the more specific errors changed in the PHPStan baseline.