Skip to content

Conversation

@williamjallen
Copy link
Collaborator

Coverage files are currently stored in the database with artificial line separators. This attempt at pre-rendering the files is problematic for a variety of reasons, all stemming from the fact that what's stored in the database is not actually what we want to be displayed. This PR adds a migration to remove these artificial separators and prevent them from being added to new records.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Jul 28, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 28, 2025
Coverage files are currently stored in the database with artificial line
separators. This attempt at pre-rendering the files is problematic for a
variety of reasons, all stemming from the fact that what's stored in the
database is not actually what we want to be displayed. This PR adds a
migration to remove these artificial separators and prevent them from
being added to new records.
Merged via the queue into Kitware:master with commit bbbc85f Jul 28, 2025
7 checks passed
@williamjallen williamjallen deleted the coveragefile-newlines branch July 28, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants