Replace note crc32 column with hash index
#2943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
Following the success of #2943, this PR applies the same principle to the `testoutput` table: remove the `crc32` column, add hash indexes, and perform exact matching to deduplicate the table rather than using a messy, low-entropy, application-layer hashing mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern versions of Postgres have good hash index support, allowing us to efficiently perform equality comparisons on large text columns. Our current crc32-based hashing system suffers from hash conflicts, in addition to adding unnecessary and easily-broken logic. This PR replaces the crc32 column with a hash index and explicit equality comparison against all fields on insertion.