Fix project and global invitation access control issues #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
May 22, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM! Can't see the invitation when I'm not supposed to!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2778 and #2830 both suffer from a logical flaw which was missed in testing because the Laravel
assertJson(..., strict: true)does not actually do an exact JSON match as it was believed to do. This PR resolves the access control issues in these unreleased features. I plan to make a separate PR to convert the rest of theassertJson()assertions throughout the codebase toassertExactJson().