Use GHA arm64 runners for arm64 image build job #2868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
May 6, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
The newly added checks all look good. Will the "expected" ones update automatically once this merges or am I missing somewhere in the repository where that will need to be updated?
Collaborator
Author
|
@josephsnyder The required jobs need to be updated manually in the repo settings. Given that we'll have to rebase everything after this goes in, what do you think about holding off on the merge until #2870 is merged? |
Collaborator
Author
|
The new action names have been added to the branch protection ruleset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current CI Docker image build uses QEMU emulation to build
arm64images. Thearm64component of the build process takes a disproportionate amount of time, and is the longest-running job in our test suite. Thanks to GitHub's newarm64runners, we can now build each architecture without emulation.