-
Notifications
You must be signed in to change notification settings - Fork 80
Remove integration with non-git repos #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove integration with non-git repos #2795
Conversation
|
While we're dropping support for version control systems we should also trim the list of viewers here: https://github.com/Kitware/CDash/blob/master/app/cdash/app/Model/Repository.php#L28 |
There are a bunch of other frontend changes related to this that also need to be made. As far as I can tell, the code you linked is only used to populate the dropdown in the UI, so I left it out of this PR deliberately. As far as I can tell, the current changes should be "safe" in that they just cause CDash systems with other repositories to lose their links to those repositories. Any objections to this approach? |
That is my understanding as well.
I'm okay splitting this effort across multiple PRs as long as we're keeping track of the corresponding frontend changes that need to be made as well. |
josephsnyder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem reasonable. I didn't find issues during brief manual testing. LGTM!
323b257 to
2fbe61c
Compare
This PR finishes the work started in #2795.
Fixes a stack trace observed in the logs of a large production system after the installation of #2795.
Fixes a stack trace observed in the logs of a large production system after the installation of #2795.
This PR removes all but GitHub and GitLab from the list of repositories CDash can integrate with. This is the first in a series of PRs reducing our integration with lesser-used external tools, paving the way for better integration with git-based tools in the future. None of the code removed in this PR is tested, and it is quite likely that some of these no longer work in the first place.