Skip to content

Conversation

@williamjallen
Copy link
Collaborator

This PR removes all but GitHub and GitLab from the list of repositories CDash can integrate with. This is the first in a series of PRs reducing our integration with lesser-used external tools, paving the way for better integration with git-based tools in the future. None of the code removed in this PR is tested, and it is quite likely that some of these no longer work in the first place.

@zackgalbreath
Copy link
Contributor

While we're dropping support for version control systems we should also trim the list of viewers here:

https://github.com/Kitware/CDash/blob/master/app/cdash/app/Model/Repository.php#L28

@williamjallen
Copy link
Collaborator Author

While we're dropping support for version control systems we should also trim the list of viewers here:

There are a bunch of other frontend changes related to this that also need to be made. As far as I can tell, the code you linked is only used to populate the dropdown in the UI, so I left it out of this PR deliberately. As far as I can tell, the current changes should be "safe" in that they just cause CDash systems with other repositories to lose their links to those repositories. Any objections to this approach?

@zackgalbreath
Copy link
Contributor

the code you linked is only used to populate the dropdown in the UI

That is my understanding as well.

the current changes should be "safe" in that they just cause CDash systems with other repositories to lose their links to those repositories. Any objections to this approach?

I'm okay splitting this effort across multiple PRs as long as we're keeping track of the corresponding frontend changes that need to be made as well.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem reasonable. I didn't find issues during brief manual testing. LGTM!

@williamjallen williamjallen added this pull request to the merge queue Apr 11, 2025
Merged via the queue into Kitware:master with commit 5a10da2 Apr 11, 2025
7 checks passed
@williamjallen williamjallen deleted the legacy-repo-removal branch April 11, 2025 14:59
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2025
This PR finishes the work started in
#2795.
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2025
Fixes a stack trace observed in the logs of a large production system
after the installation of #2795.
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2025
Fixes a stack trace observed in the logs of a large production system
after the installation of #2795.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants