Add build instrumentation API #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
build-instrumentation
branch
from
ecb9e63 to
59f0bbc
Compare
williamjallen
changed the title
williamjallen
force-pushed
the
build-instrumentation
branch
2 times, most recently
from
a4106b9 to
9128d2d
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
2 times, most recently
from
ee592af to
9811123
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
This PR pulls out some of the logic in #2612 for matching full XML paths into a separate PR in anticipation of several upcoming PRs. By specifying the full XML path for an element, the exact element being targeted is more clear. For the sake of example, I used the new path method to locate all of the `<Site>` elements.
williamjallen
force-pushed
the
build-instrumentation
branch
from
9811123 to
e1d4d62
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
6 times, most recently
from
6fe8a11 to
02f18e7
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
2 times, most recently
from
78a147b to
0d9f57f
Compare
josephsnyder
approved these changes
Mar 12, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM! once the data was properly added into the database, it made sense and was able to be pulled out in GraphQL. As discussed F2F, I'm not a big fan of command and commands being attributes on the build but I'm not willing to let that stop this from moving forward
williamjallen
force-pushed
the
build-instrumentation
branch
from
0d9f57f to
e7d81a8
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
3 times, most recently
from
d02443c to
84312b9
Compare
josephsnyder
approved these changes
Apr 2, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Thanks for the quick help, Everything here LGTM
williamjallen
force-pushed
the
build-instrumentation
branch
2 times, most recently
from
a95ca23 to
210697a
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
from
210697a to
18a350e
Compare
zackgalbreath
approved these changes
Apr 21, 2025
williamjallen
force-pushed
the
build-instrumentation
branch
from
18a350e to
1764b27
Compare
williamjallen
force-pushed
the
build-instrumentation
branch
from
1764b27 to
91cf21f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2025
Following the work started in #2612, this PR adds supports for the `output` and `outputSizes` [snippet file](https://cmake.org/cmake/help/latest/manual/cmake-instrumentation.7.html#v1-snippet-file) fields.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2025
Following the work started in #2612, this PR adds supports for the `output` and `outputSizes` [snippet file](https://cmake.org/cmake/help/latest/manual/cmake-instrumentation.7.html#v1-snippet-file) fields.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
Building on top of #2612, this PR adds a new "build targets" page which displays a table of targets for a build if instrumentation data was submitted. See #2827 for more details about the outline for our new instrumentation-related pages. I have a number of future improvements in mind for this page, including better support when viewing parent builds, correlation to errors & warnings with associated color highlighting, customizable timing or other measurement columns, a trace-style view of the targets or other at the top of the page. <img width="2834" height="944" alt="image" src="https://github.com/user-attachments/assets/1a84ad9d-1197-4c38-a696-8c935c3116ef" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the initial build instrumentation work in #2460 with a more complete version based on a working CMake/CTest implementation. See #2395 for the full feature request.
I plan to make a follow-up PR to add support for configure measurements once a handful of blocking database schema changes are completed. Future PRs will also implement various UIs to display the data collected here.