Skip to content

Standardize usages of PHPUnit's assertEquals() #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamjallen merged 1 commit into from
Dec 10, 2023
Merged

Standardize usages of PHPUnit's assertEquals() #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/cdash/tests/case/CDash/LinkifyCompilerOutputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ public function testLinkifyCompilerOutput()

$expected_output = "<a href='https://github.com/Kitware/CDash/blob/master/file.cxx#L1'>file.cxx:1</a>:22: error: &lt;fakefile.h&gt;: No such file";

$this->assertEquals($linkified_output, $expected_output);
$this->assertEquals($expected_output, $linkified_output);
}
}
40 changes: 20 additions & 20 deletions app/cdash/tests/case/CDash/TestUseCaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,26 +103,26 @@ public function testTestUseCaseCreatesBuildAndSiteInformation()
$build = $builds->current();
$information = $build->GetSite()->mostRecentInformation;

$this->assertEquals($information->description, $siteInformation['Description']);
$this->assertEquals($information->processoris64bits, $siteInformation['Is64Bits']);
$this->assertEquals($information->processorvendor, $siteInformation['VendorString']);
$this->assertEquals($information->processorvendorid, $siteInformation['VendorID']);
$this->assertEquals($information->processorfamilyid, $siteInformation['FamilyID']);
$this->assertEquals($information->processormodelid, $siteInformation['ModelID']);
$this->assertEquals($information->processorcachesize, $siteInformation['ProcessorCacheSize']);
$this->assertEquals($information->numberlogicalcpus, $siteInformation['NumberOfLogicalCPU']);
$this->assertEquals($information->numberphysicalcpus, $siteInformation['NumberOfPhysicalCPU']);
$this->assertEquals($information->totalvirtualmemory, $siteInformation['TotalVirtualMemory']);
$this->assertEquals($information->totalphysicalmemory, $siteInformation['TotalPhysicalMemory']);
$this->assertEquals($information->logicalprocessorsperphysical, $siteInformation['LogicalProcessorsPerPhysical']);
$this->assertEquals($information->processorclockfrequency, $siteInformation['ProcessorClockFrequency']);

$this->assertEquals($build->Information->osname, $siteInformation['OSName']);
$this->assertEquals($build->Information->osrelease, $siteInformation['OSRelease']);
$this->assertEquals($build->Information->osversion, $siteInformation['OSVersion']);
$this->assertEquals($build->Information->osplatform, $siteInformation['OSPlatform']);
$this->assertEquals($build->Information->compilername, $siteInformation['CompilerName']);
$this->assertEquals($build->Information->compilerversion, $siteInformation['CompilerVersion']);
$this->assertEquals($siteInformation['Description'], $information->description);
$this->assertEquals($siteInformation['Is64Bits'], $information->processoris64bits);
$this->assertEquals($siteInformation['VendorString'], $information->processorvendor);
$this->assertEquals($siteInformation['VendorID'], $information->processorvendorid);
$this->assertEquals($siteInformation['FamilyID'], $information->processorfamilyid);
$this->assertEquals($siteInformation['ModelID'], $information->processormodelid);
$this->assertEquals($siteInformation['ProcessorCacheSize'], $information->processorcachesize);
$this->assertEquals($siteInformation['NumberOfLogicalCPU'], $information->numberlogicalcpus);
$this->assertEquals($siteInformation['NumberOfPhysicalCPU'], $information->numberphysicalcpus);
$this->assertEquals($siteInformation['TotalVirtualMemory'], $information->totalvirtualmemory);
$this->assertEquals($siteInformation['TotalPhysicalMemory'], $information->totalphysicalmemory);
$this->assertEquals($siteInformation['LogicalProcessorsPerPhysical'], $information->logicalprocessorsperphysical);
$this->assertEquals($siteInformation['ProcessorClockFrequency'], $information->processorclockfrequency);

$this->assertEquals($siteInformation['OSName'], $build->Information->osname);
$this->assertEquals($siteInformation['OSRelease'], $build->Information->osrelease);
$this->assertEquals($siteInformation['OSVersion'], $build->Information->osversion);
$this->assertEquals($siteInformation['OSPlatform'], $build->Information->osplatform);
$this->assertEquals($siteInformation['CompilerName'], $build->Information->compilername);
$this->assertEquals($siteInformation['CompilerVersion'], $build->Information->compilerversion);
}

public function testTestUseCaseSetsSiteProperty()
Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/MeasurementPositionMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function testMeasurementPositionMigration()
'--force' => true]);

// Verify results.
$this::assertEquals(DB::table('measurement')->count(), 6);
$this::assertEquals(6, DB::table('measurement')->count());
$expected_measurements = [
[
'projectid' => $project1->Id,
Expand Down
6 changes: 3 additions & 3 deletions tests/Feature/TestSchemaMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public function testMigrationOfTestTables()
'--force' => true]);

// Verify results.
$this::assertEquals(DB::table('test')->count(), 3);
$this::assertEquals(3, DB::table('test')->count());
$expected_tests = [
[
'name' => 'a test',
Expand All @@ -193,7 +193,7 @@ public function testMigrationOfTestTables()
$this->assertDatabaseHas('test', $expected_test);
}

$this::assertEquals(DB::table('testoutput')->count(), 4);
$this::assertEquals(4, DB::table('testoutput')->count());
$expected_testoutputs = [
[
'crc32' => 123,
Expand All @@ -219,7 +219,7 @@ public function testMigrationOfTestTables()
}

foreach (['build2test', 'label2test', 'test2image', 'testmeasurement'] as $table) {
$this::assertEquals(DB::table($table)->count(), 4);
$this::assertEquals(4, DB::table($table)->count());
$this->assertDatabaseHas($table, ['outputid' => 1]);
$this->assertDatabaseHas($table, ['outputid' => 2]);
$this->assertDatabaseHas($table, ['outputid' => 3]);
Expand Down