Set Carthage Swift version to 4.2 (Swift 4 + 5 compatibility) #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erikkerber
changed the title
Contributor
Author
|
@djones6 Have any thoughts on this? That license CI step is stuck at yellow, not sure how to kick that over. |
ianpartridge
approved these changes
Mar 6, 2019
Contributor
|
Not sure but I've merged for you! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Swift version to 4.2 in the Carthage support Xcode project
Motivation and Context
The current Xcode project specifies Swift 3. This will be incompatible with Swift 5 being released shortly in Xcode 10.2.
By specifying Swift 4.2, swift-html-entities will be compatible with both Swift 4.2 and Swift 5.
How Has This Been Tested?
Carthage build using Xcode 10.1 and Xcode 10.2 beta 3 as the set toolchains.
After reading below I will get a CLA form signed shortly!
Checklist: