Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snapshot bot upload the changes instead of commit #5271

Closed
wants to merge 9 commits into from
Closed

Make snapshot bot upload the changes instead of commit #5271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
033eaed
Make snapshot bot upload the changes instead of commit
pierremtb Feb 5, 2025
3300993
Separate snapshot from flow tests
pierremtb Feb 5, 2025
0d148e8
Clean up
pierremtb Feb 5, 2025
f4a4e6c
Upload only the changes
pierremtb Feb 5, 2025
ba8f8a1
WIP
pierremtb Feb 5, 2025
824669a
WIP
pierremtb Feb 5, 2025
465e71c
WIP
pierremtb Feb 5, 2025
87e299e
Merge branch 'main' into pierremtb/make-snapshot-bot-upload-instead-o…
pierremtb Feb 5, 2025
7c93574
Update snapshots from the upload artifact run
pierremtb Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP
  • Loading branch information
@pierremtb
pierremtb committed Feb 5, 2025
commit ba8f8a17223cc994abb1abbf82635620092ad664
2 changes: 1 addition & 1 deletion .github/workflows/e2e-flow-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
rust:
- 'src/wasm-lib/**'

electron:
electron-tests:
timeout-minutes: 60
name: playwright:electron:${{ matrix.os }} ${{ matrix.shardIndex }} ${{ matrix.shardTotal }}
strategy:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/e2e-snapshot-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
rust:
- 'src/wasm-lib/**'

test:
snapshot-test:
runs-on: ubuntu-22.04
needs: check-rust-changes
steps:
Expand Down Expand Up @@ -75,6 +75,7 @@ jobs:
continue-on-error: true

- name: Setup Rust
if: needs.check-rust-changes.outputs.rust-changed == 'true'
uses: dtolnay/rust-toolchain@stable

- name: Cache Wasm (because rust diff)
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default defineConfig({
/* Configure projects for major browsers */
projects: [
{
name: 'chromium',
name: 'Google Chrome',
use: {
...devices['Desktop Chrome'],
channel: 'chrome',
Expand Down
Loading